[58256] Header and sidebar menu should be hidden while pressing zen mode button #17045
+30
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent, and update primer-view components
ulferts
reviewed
Oct 25, 2024
| if (isActive) { | ||
| document.body.classList.add('zen-mode'); | ||
| } else { | ||
| document.body.classList.remove('zen-mode'); |
There was a problem hiding this comment.
💡 You can simplify the whole method by using toggle
window.addEventListener('zenModeToggled', (event:CustomEvent) => {
document.body.classList.toggle('zen-mode', event.detail.active)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/58256/activity
What are you trying to accomplish?
Update core with new version of primer view components. Listen to the toggledZenMode event and set/remove zen-mode class on body element.